Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts not being deleted when deleting task #112

Closed
mmiller-max opened this issue Feb 24, 2022 · 12 comments
Closed

Artifacts not being deleted when deleting task #112

mmiller-max opened this issue Feb 24, 2022 · 12 comments

Comments

@mmiller-max
Copy link
Contributor

When I delete a task using the Web GUI, I see the following message:
Screenshot 2022-02-24 at 09 51 15

When I check the fileserver in the VM on which it's running, I can see that the artifacts are still there, for example at the location /opt/clearml/data/fileserver/project/task/artifacts/...

So there seems to be two issues, one with artifacts not being deleted (which I wasn't aware happened with previous version of server) and one with the error message not showing what hasn't been deleted.

Server version is 1.2.0 running on GCP. Cheers!

@jkhenning
Copy link
Member

Hi @mmiller-max ,

Any more info? Is this reproducible? If so, can you share a small code snippet that creates a task which exhibits this behavior when deleted using the UI?

@mmiller-max
Copy link
Contributor Author

mmiller-max commented Feb 24, 2022

For me just this creates the error:

from clearml import Task
task = Task.init()
task.upload_artifact("artifact", {"1":1})

Then Ctrl+C and delete in UI.

And yep it's reproducible. Could it be a file permissions thing perhaps?

@jkhenning
Copy link
Member

Well, seems like an obvious but - we'll take a look, I'll update!

@mmiller-max
Copy link
Contributor Author

Cheers @jkhenning !

@mmiller-max
Copy link
Contributor Author

Trying to do a bit of debugging on this but can't see anything in the fileserver logs. Do I need to set something in logging.conf in either the file server or the api server?

@jkhenning
Copy link
Member

I think you should see console logs. The issue might be in the WebApp...

@mmiller-max
Copy link
Contributor Author

mmiller-max commented Mar 29, 2022

I think this is the corresponding web app log but can't see any errors with it:

35.191.10.5 - - [29/Mar/2022:13:52:30 +0000] "POST /api/v2.16/tasks.delete_many HTTP/1.1" 200 395 "https://app.{domain}/projects/c28adf12db964d169a645f5351a669de/experiments?columns=selected&columns=type&columns=name&columns=tags&columns=status&columns=project.name&columns=users&columns=started&columns=last_update&columns=last_iteration&columns=parent.name&order=-last_update&filter=&archive=true" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.2 Safari/605.1.15" "195.224.76.82,34.149.227.91"

@mmiller-max
Copy link
Contributor Author

Another bit of information, I only get undefined in the error message if using the fileserver subdomain for the files (e.g. https://files.domain.com. If I use a different URL (e.g. GCP bucket) it displays the URL (but still fails to delete)

@mmiller-max
Copy link
Contributor Author

This seems to be cropping up often in slack, e.g. here, here and here. It seems to be agnostic of whether the files are stored on the same VM as the server or elsewhere, and seems to be an issue in the Web App as there are no logs in the fileserver.

@mmiller-max
Copy link
Contributor Author

One further comment, I'm pretty sure I never saw this error with ClearML Server v1.1.1

@mmiller-max
Copy link
Contributor Author

After updating to the latest server (1.9.1) I'm no longer seeing these errors so going to close this 👏

@ainoam
Copy link
Collaborator

ainoam commented Jan 17, 2023

Appreciate the update @mmiller-max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants