Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.17.5 RCs do not detect scikit-learn dependency #296

Closed
odedbd opened this issue Jan 27, 2021 · 7 comments
Closed

0.17.5 RCs do not detect scikit-learn dependency #296

odedbd opened this issue Jan 27, 2021 · 7 comments

Comments

@odedbd
Copy link

odedbd commented Jan 27, 2021

I've been testing 0.17.5rc0-0.17.5rc2 and scikit-learn dependency isn't being detected. As a result my scripts, which used to run fine on remote, fail on import sklearn. I verified that indeed scikit-learn is not listed in the dependencies for the task. Reverting to 0.17.4 resolved this issues.

@bmartinn
Copy link
Member

Thanks @odedbd
I was able to locate the issue, a fix will be ready soon, I'll update here.
BTW: This will only affect scikit-learn, since the import is different from the package naming :)

@odedbd
Copy link
Author

odedbd commented Jan 28, 2021

@bmartinn that's great. Is there an option to manually register dependencies, in a addition to the automagical discovery? Some API like task.add_dependency('package_name',version=None) where version is optional if you want to just grab the latest? With such an API I could fix such a problem on my end, at least until it would be solved "properly".

@jkhenning
Copy link
Member

Hi @odedbd ,

Is there an option to manually register dependencies, in a addition to the automagical discovery? Some API like task.add_dependency('package_name',version=None) where version is optional if you want to just grab the latest?

Yes indeed, you can use:
task.add_requirements(package_name, package_version=None)

🙂

@odedbd
Copy link
Author

odedbd commented Jan 28, 2021

That's good to know 👍

@bmartinn
Copy link
Member

bmartinn commented Feb 5, 2021

@odedbd
Updating here the latest RC fixes this issue, please feel free to test:

pip install clearml==0.17.5rc3

@odedbd
Copy link
Author

odedbd commented Feb 7, 2021

Working, thanks!

@odedbd odedbd closed this as completed Feb 7, 2021
@graelo
Copy link

graelo commented May 8, 2023

Hi,

For future readers, the api for manually registering dependencies is currently a class method (note the Task, not task)

Task.add_requirements("requests", "2.29.0")

and this statement must be placed before Task.init(...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants