Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Trains intranet and k8s friendly #30

Closed
soyvv opened this issue Jul 26, 2019 · 7 comments
Closed

make Trains intranet and k8s friendly #30

soyvv opened this issue Jul 26, 2019 · 7 comments

Comments

@soyvv
Copy link

soyvv commented Jul 26, 2019

Hi there,
Great project and thank you so much for sharing it!
I'm trying to set up the Train services on our intranet-based (which blocks internet connection) K8S cluster and faces the following issues:

  1. the Train docker container (for web) has hard-coded the backend server ports (8008 etc), which makes it hard for K8S to dynamically link the train web server and backend service; could you make the ports configurable externally?
  2. There're some internet resource links in the webapp, which, in our intranet environment, cannot be loaded. Would it be possible to pack all resources inside the docker images? Or provide an "offline" mode to inject pre-downloaded resources.

Thanks and Best Regards.

zhikai

@bmartinn
Copy link
Member

bmartinn commented Jul 26, 2019

Thank you for the kind words, feel free to share, star and fork :)

Answering your questions:

  1. See trains-server on Kubernetes issue
    Did you check these?
    https://github.com/allegroai/trains-server-k8s
    https://github.com/allegroai/trains-server-helm

  2. Do you have a specific resource you know of?
    The only thing that comes to mind is the plotly.js package (that we fetch from a CDN).
    Adding that to the web package is on our to do list, is there anything else we missed?

@bmartinn
Copy link
Member

bmartinn commented Aug 3, 2019

Closing, feature implemented.

@bmartinn bmartinn closed this as completed Aug 3, 2019
@eladrich
Copy link

Hi,
Really enjoying this project, amazing work!
Are you still planning to add plotly.js to the package so it can run "offline"?

I'm using the trains-server on-premise and everything works great except for plotly.

Best,
Elad

@bmartinn
Copy link
Member

Hi @eladrich thank you so much for the feedback, really appreciate it!
I know it was on the to do list for the upcoming version (coming really soon ;)
But let me check and get back to you...

@bmartinn
Copy link
Member

@eladrich good news 🎉 plotly.js will be served by the trains-server in the upcoming release :)

@eladrich
Copy link

Awesome🤘, thanks!

@bmartinn
Copy link
Member

@eladrich
🎊 v0.12 is out with plotly.js served by the trains server and Full DevOps and AutoML!
Read all about it https://github.com/allegroai/trains-agent 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants