New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove subdir
path from GCP bucket url
#1117
Conversation
Hi @materight, If the bucket has a specific subdir defined in the configuration, wouldn't it make sense to check these permissions on the subdir? Or are you saying this is not supported in Google Storage? |
Hi @jkhenning. The second one, this method works only on buckets: https://cloud.google.com/storage/docs/json_api/v1/buckets/testIamPermissions |
@materight got it 👍 |
In that specific case, how did you set the default output destination? I'm not sure I get how marking out the subdir will prevent that, since the line that basically causes the file to be mentioned in the request is the one setting the blob to the test_obj, and when setting a default output_uri you do not specify a file - do how did the file end up there? |
So this is something I couldn't figure out, I just call But the main problem here is that the subdir is passed as |
That makes sense, but it wouldn't yield the same error 😕 |
Sorry, what do you mean? |
If |
Ah got it. If you can give me some hint on how/where this |
It can basically be set in the configuration file's |
I have this in the config file:
Also in the agent's logs I only see this:
Btw I'm using pipelines, the |
And can you reproduce that error message you shared? |
Yes, if I clone the failed task and re-enqueue it I get the same error. But if I run a new task it doesn't happen all the time. |
The config file you attached is from your own workstation? If so, what's the config file used by the agent? |
It's exactly the same for both |
And the task log in the remote run where it happens? Can you share? |
Sure, here: task_ff8c8917072641bca89f27ddd488d74c.log |
Hi @jkhenning any update on this? Would it be possible to merge it and dig in more if the issue reappear? |
Patch Description
When running a cloned task remotely and using GS as storage, calling
task.logger.set_default_upload_destination
usually fails with an error like:This is because the permissions are being tested on a single file instead of a GS bucket. Removing the
subdir
from the bucket url should fix it.Testing Instructions
task.logger.set_default_upload_destination