Fix/argparse warning #576
Merged
Fix/argparse warning #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhenning
reviewed
Feb 9, 2022
clearml/binding/args.py
Outdated
| if not PatchArgumentParser._original_parse_args | ||
| else PatchArgumentParser._original_parse_args(self, args=args, namespace=namespace) | ||
| ) | ||
| warnings.warn("Error when patching arguments: %s" % e) |
There was a problem hiding this comment.
If this is specific to argparse, I think the error should mention argparse, something like "Failed patching argparse arguments: %s"
There was a problem hiding this comment.
now having more relevant warnings
shomratalon
approved these changes
Feb 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is an issue patching the Argparser raise a warning for the user (so it won't fail running remotely).