Skip to content

Commit

Permalink
Fix calculate shape stats to use same coeff columns (#9)
Browse files Browse the repository at this point in the history
  • Loading branch information
jessicasyu committed Feb 17, 2023
1 parent 2ea6742 commit b422215
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/abm_shape_collection/calculate_shape_stats.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,17 @@ def calculate_shape_stats(
) -> pd.DataFrame:
all_stats = []

data_transform = pca.transform(data.filter(like="shcoeffs").values)
ref_data_transform = pca.transform(ref_data.filter(like="shcoeffs").values)
columns = ref_data.filter(like="shcoeffs").columns
data_transform = pca.transform(data[columns].values)
ref_data_transform = pca.transform(ref_data[columns].values)

for component in range(components):
ks_stats = get_ks_statistic(data_transform[:, component], ref_data_transform[:, component])
ks_stats.update({"FEATURE": f"PC_{component + 1}", "TICK": np.nan})
all_stats.append(ks_stats)

for tick, tick_data in data.groupby("TICK"):
tick_data_transform = pca.transform(tick_data.filter(like="shcoeffs").values)
tick_data_transform = pca.transform(tick_data[columns].values)

for component in range(components):
tick_ks_stats = get_ks_statistic(
Expand Down

0 comments on commit b422215

Please sign in to comment.