Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ColorRamp selector into a react component #75

Closed
Tracked by #52
ShrimpCryptid opened this issue Aug 30, 2023 · 1 comment
Closed
Tracked by #52

Refactor ColorRamp selector into a react component #75

ShrimpCryptid opened this issue Aug 30, 2023 · 1 comment
Labels
internals Tech debt, refactoring, dependencies, etc.

Comments

@ShrimpCryptid
Copy link
Contributor

Acceptance Criteria

  • Move logic from App into its own file.
  • ColorRampSelector should be used in App as a simple component, e.g.
<ColorRampSelector
   onChange={...}
   ramps={...}
   selected={...}
/>
@ShrimpCryptid ShrimpCryptid added the internals Tech debt, refactoring, dependencies, etc. label Aug 30, 2023
@ShrimpCryptid ShrimpCryptid changed the title Refactor ColorRamp selector into a react component. Refactor ColorRamp selector into a react component Aug 30, 2023
@toloudis toloudis mentioned this issue Aug 30, 2023
Closed
11 tasks
@ShrimpCryptid ShrimpCryptid mentioned this issue Sep 11, 2023
Merged
ShrimpCryptid added a commit that referenced this issue Sep 15, 2023
@ShrimpCryptid
merge: pull request #97 from allen-cell-animated/feature/ui-update-2
44a989a 
feat: UI Update 2 - Collections and Color Ramp Selection

Resolves #75, #49, and #78.

Adds a new component, ColorRampSelector.tsx.
Refactors Collections into a new class; these changes simplify handling datasets and collections.
Adds a modal button, LoadDatasetButton.tsx, for opening new datasets or collections from the UI.
@ShrimpCryptid
Copy link
Contributor Author

Closed with #97!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internals Tech debt, refactoring, dependencies, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShrimpCryptid