Patch other S3 methods with 404 detection fix

allenai · Mar 15, 2024 · 666da70 · 666da70
1 parent 0b6e28c
commit 666da70
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/olmo/util.py b/olmo/util.py
@@ -501,7 +501,7 @@ def _s3_upload(
                     f"s3://{bucket_name}/{key} already exists. Use save_overwrite to overwrite it."
                 )
             except boto_exceptions.ClientError as e:
-                if int(e.response["Error"]["Code"]) == 404:
+                if e.response["ResponseMetadata"]["HTTPStatusCode"] == 404:
                     err = None
                     break
                 err = e
@@ -525,7 +525,7 @@ def _s3_file_size(scheme: str, bucket_name: str, key: str, max_attempts: int = 3
         try:
             return _get_s3_client(scheme).head_object(Bucket=bucket_name, Key=key)["ContentLength"]
         except boto_exceptions.ClientError as e:
-            if int(e.response["Error"]["Code"]) == 404:
+            if e.response["ResponseMetadata"]["HTTPStatusCode"] == 404:
                 raise FileNotFoundError(f"s3://{bucket_name}/{key}") from e
             err = e