Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack small PPL eval sets together #199

Merged
merged 12 commits into from
Jun 7, 2023
Merged

Pack small PPL eval sets together #199

merged 12 commits into from
Jun 7, 2023

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Jun 2, 2023

Adds the ability to handle multiple language modeling evaluation datasets in a single Evaluator while still tracking metrics for each dataset separately.
This allows us to pack small perplexity evaluation datasets together to make the evaluation loop more efficient and to handle datasets that are too small to use otherwise (because they don't have enough examples for a single batch on all GPUs).

I did a test run to validate the code. Here are the results: https://wandb.ai/ai2-llm/c4-small/reports/Packed-evaluations--Vmlldzo0NTY2Mzg2

Comment on lines +57 to +81
tokenizer:
identifier: gpt2
truncate_direction: right

save_folder: ${path.choose:${oc.env:SCRATCH_DIR,no_exist}/checkpoints,/results}/${oc.env:SLURM_JOB_ID,${run_name}}
save_overwrite: false
# Sharded checkpoints (best for restarts)
save_interval: 1000
save_num_checkpoints_to_keep: 2
# Unsharded checkpoints (for final storage)
save_interval_unsharded: 10000
save_num_unsharded_checkpoints_to_keep: -1

load_path: null

max_duration: 476837 # 2T tokens
global_train_batch_size: 2048
device_train_microbatch_size: 4

precision: amp_bf16

max_grad_norm: 1.0

speed_monitor:
window_size: 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's all this? Should it be in this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's just moved?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, just moved so we don't have to scroll past all of the evaluation settings to find the other settings.

@epwalsh epwalsh merged commit 86060d4 into main Jun 7, 2023
10 checks passed
@epwalsh epwalsh deleted the packed-evals branch June 7, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants