-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layer norm affine manual layer norm turned off for safety #264
Layer norm affine manual layer norm turned off for safety #264
Conversation
…fine-ManualLayerNorm # Conflicts: # scripts/v1-mix-medium-on-lumi.sh
@epwalsh, I think this is ready. |
configs/v1-mix-medium.yaml
Outdated
@@ -20,7 +20,8 @@ model: | |||
include_bias: false | |||
block_type: sequential | |||
layer_norm_type: low_precision | |||
layer_norm_with_affine: false | |||
#layer_norm_with_affine: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still a field in the config, so why is it commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted it to revert to default, but I can make it explicit.
Can we merge and kick this off? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.