Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix occasional KeyError in S3 logic #301

Merged
merged 9 commits into from
Sep 30, 2023
Merged

Fix occasional KeyError in S3 logic #301

merged 9 commits into from
Sep 30, 2023

Commits on Sep 28, 2023

  1. Added retries to and updated exception logic of _s3_get_bytes_range

    @2015aroras
    2015aroras committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8f94005 View commit details
    Browse the repository at this point in the history

  2. Increase _s3_get_bytes_range attempts to 3 

    Co-authored-by: Pete <epwalsh10@gmail.com>
    @2015aroras @epwalsh
    2015aroras and epwalsh committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    547b564 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Address PR comments 

    - Add retry and OlmoNetworkError transform to all s3 methods
- Add exponental-backoff delay to retries
- Fix linter issues
- Fixed e.e. typo
    @2015aroras
    2015aroras committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    4394c2a View commit details
    Browse the repository at this point in the history

  2. Remove empty line to fix linting issue

    @2015aroras
    2015aroras committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    87a29dd View commit details
    Browse the repository at this point in the history

  3. Address PR comments 

    - Add warning logs on s3 retries
- Add retry s3 client config
    @2015aroras
    2015aroras committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    6682c77 View commit details
    Browse the repository at this point in the history

  4. Disambiguate botocore exceptions from other exceptions

    @2015aroras
    2015aroras committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    92d1ce8 View commit details
    Browse the repository at this point in the history

  5. Fix undefined name error

    @2015aroras
    2015aroras committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e639b77 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into shanea/fix-s3-keyerror-failures

    @epwalsh
    epwalsh committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    ed41b62 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. Merge branch 'main' into shanea/fix-s3-keyerror-failures

    @2015aroras
    2015aroras committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    019ecf3 View commit details
    Browse the repository at this point in the history