Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small simplifications #377

Merged
merged 7 commits into from
Nov 22, 2023
Merged

Small simplifications #377

merged 7 commits into from
Nov 22, 2023

Conversation

Muennighoff
Copy link
Collaborator

@Muennighoff Muennighoff commented Nov 22, 2023

Discussed in #356

Only made minor changes - lmk if there are more parts you'd like me to modify!

Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think the elementwise affine logic in LN needs to be updated

olmo/model.py Outdated Show resolved Hide resolved
olmo/model.py Outdated Show resolved Hide resolved
Muennighoff and others added 3 commits November 22, 2023 13:48
Co-authored-by: Pete <epwalsh10@gmail.com>
Co-authored-by: Pete <epwalsh10@gmail.com>
@Muennighoff Muennighoff merged commit dcdadc5 into main Nov 22, 2023
10 checks passed
@Muennighoff Muennighoff deleted the Muennighoff/split-model-comps branch November 22, 2023 22:04
@Muennighoff Muennighoff mentioned this pull request Jan 7, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants