initialize distributed group before logging #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2015aroras
approved these changes
Dec 1, 2023
| @@ -46,9 +46,9 @@ def main(cfg: TrainConfig) -> None: | |||
| "setting has no effect." | |||
| ) | |||
|
|
|||
| # Initialize process group and set device. | |||
| dist.init_process_group(backend="nccl") | |||
| barrier() | |||
There was a problem hiding this comment.
Should you also move the barrier()?
There was a problem hiding this comment.
The placement of this barrier is pretty arbitrary, so I think it's fine to keep here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to our
torch_utilsmessed up how we configure logging in a distributed-aware way. As a result every rank was logging on LUMI. To fix that we just need to initialize the distributed process group before configuring logging.