[Storage Cleaner] Unsharding improvements #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
approved these changes
Mar 5, 2024
| for sharded_checkpoint_dir in sharded_checkpoint_directories | ||
| if _get_checkpoint_number(sharded_checkpoint_dir) == checkpoint_num | ||
| ] | ||
| assert len(sharded_checkpoint_directories) <= 1 |
There was a problem hiding this comment.
Will this script warn anywhere if there are no matching checkpoints here?
There was a problem hiding this comment.
It will say (as an info log, line 817) there are no matching directories and then will exit gracefully. There will be ~10 lines of logs from the whole program in this scenario, so it won't be a needle in a haystack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a few PRs with refactored versions of changes I have been using locally for checkpoint management. This PR focusses on my changes to the storage cleaner's unsharding functionality:
TrainConfig. This has been done in a hacky way (passing an emptyTrainConfigto the checkpointer), relying on the fact that unsharding doesn't use the config at all.