Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics broken in room 223 #28

Closed
YangZhang4065 opened this issue Feb 3, 2018 · 5 comments
Closed

Physics broken in room 223 #28

YangZhang4065 opened this issue Feb 3, 2018 · 5 comments

Comments

@YangZhang4065
Copy link

Hi, part of the walls are not physical entities in FloorPlan 223. And the result is that the agent could move freely through the wall without any obstacles. This happens when the agent keeps moving ahead right after default initialization.

Minimum code to reproduce the error (on my ubuntu machine):

import ai2thor.controller

GRID_SIZE=0.5

controller = ai2thor.controller.Controller()
controller.start()
controller.reset('FloorPlan223')
controller.step(dict(action='Initialize', gridSize=GRID_SIZE))
for i in range(10):
    controller.step(dict(action='MoveAhead'))
@ekolve
Copy link

ekolve commented Feb 5, 2018

Could you send me the following? Immediately after calling Initialize:

event = controller.step(dict(action='Initialize', gridSize=GRID_SIZE))
print(event.metadata['agent']['position') # Add this to the 

and at the point just prior to passing through the wall from the 'MoveAhead' action print out the agent position again and send that. If you can capture grab the image as well that would be helpful.

I checked all the walls for that and couldn't find any part that was missing a collider - as well I used a different agent to manually control the movement and explored the entire room and couldn't find a spot that allowed me to pass through.

@YangZhang4065
Copy link
Author

Sure. Here are the images&locations of the agents upon initialization, before crossing the wall and after crossing the wall.

import ai2thor.controller
from matplotlib import pyplot as plt

GRID_SIZE=0.5

controller = ai2thor.controller.Controller()
controller.start()
controller.reset('FloorPlan223')
event=controller.step(dict(action='Initialize', gridSize=GRID_SIZE))
#initialization
print(event.metadata['agent']['position'])

{'y': 1.0, 'z': -0.5, 'x': -1.0}

plt.imshow(event.frame, interpolation='nearest')
plt.show()

image

#two steps before acrossing the wall
for i in range(5):
   event=controller.step(dict(action='MoveAhead'))
print(event.metadata['agent']['position'])

{'x': -1.0, 'y': 0.9800000190734863, 'z': 2.0}

plt.imshow(event.frame, interpolation='nearest')
plt.show()

image

#right before acrossing the wall
event=controller.step(dict(action='MoveAhead'))
print(event.metadata['agent']['position'])

{'x': -1.0, 'y': 0.7721520662307739, 'z': 2.5}

plt.imshow(event.frame, interpolation='nearest')
plt.show()

image

#right after acrossing the wall
event=controller.step(dict(action='MoveAhead'))
print(event.metadata['agent']['position'])

{'x': -1.0, 'y': -5450.7158203125, 'z': 3.0}

plt.imshow(event.frame, interpolation='nearest')
plt.show()

image

@ekolve ekolve closed this as completed Feb 5, 2018
@ekolve ekolve reopened this Feb 5, 2018
@ekolve
Copy link

ekolve commented Feb 5, 2018

Okay, I am able to reproduce this now.

@ekolve
Copy link

ekolve commented Feb 5, 2018

Issue is fixed with latest release, please upgrade to version 0.0.14

@ekolve ekolve closed this as completed Feb 5, 2018
@YangZhang4065
Copy link
Author

Thank you!

Lucaweihs added a commit that referenced this issue Sep 9, 2021
Minor missing items form PR25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants