Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naive scale to nanna #1091

Merged
merged 60 commits into from
Oct 13, 2022
Merged

Naive scale to nanna #1091

merged 60 commits into from
Oct 13, 2022

Commits on Aug 31, 2022

  1. Configuration menu
    Copy the full SHA
    3bd9b1e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    388e2e4 View commit details
    Browse the repository at this point in the history
  3. more changes to light manager

    winthos committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    b379c06 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. editor light naming tools updated

    functionality for the <Name All Scene Light Objects> editor menu function complete. This names all lights with the naming convention {prefab name/scene}|{light type}|{instance count} for all lights found in scenes in the build menu.
    winthos committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    841b0e1 View commit details
    Browse the repository at this point in the history
  2. Improving GUID object name appending editor script

    updating script to append a GUID to sim objects so that it now can append them across all scenes included in the build, as well as ensures that no GUIDs are re-used and are guaranteed unique across the entire framework.
    winthos committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    922b114 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b28c220 View commit details
    Browse the repository at this point in the history
  4. rename all sim objects with new GUID

    to ensure no sim objects were missed across iTHOR, RoboTHOR, and ArchitecTHOR scenes, all sim objects currently in those scenes have had their GUID updated. To be released in next version.
    winthos committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    9fdca65 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3e74966 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Configuration menu
    Copy the full SHA
    a10d78d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1769877 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fc8abcf View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2022

  1. Configuration menu
    Copy the full SHA
    a0be6cb View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. further changes to light manager and serialization

    -Moving the logic of GetLights() to the UtilityFunctions.cs file
    -adding editor-debug function to test light serialization to text file
    -removed redundant LightProperties class and instead using LightParameters from procedural
    winthos committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    b8479b1 View commit details
    Browse the repository at this point in the history
  2. add CreateSkybox

    mattdeitke committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    48c81a1 View commit details
    Browse the repository at this point in the history
  3. newScene to debug input

    mattdeitke committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    f9e4ba4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d0fd558 View commit details
    Browse the repository at this point in the history
  5. Toggle light changes

    in order to expose controlled light objects from sim objects that can toggle on/off, edits must be made to split the use of the "light sources" array of game objects within the ToggleOnOff.cs logic.
    
    Previously the LightSources[] array was used both for light objects and any other game objects that needed to be toggled, like particle effects. These must now be disambiguated and have been split into two new arrays of referenced objects, LightSources[] and effects[]. Because of this, the reference links to all lightsources for all toggelable objects is broken and prefabs must be updated, as well as instanced sim object prefabs that don't have the referenced effects/lights built into the prefab (like lightswitches) must be updated across all scenes.
    winthos committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    ff75436 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Create NormalsVisualizer.cs.meta

    adding missing meta file for whatever NormalsVisualizer is
    winthos committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    62a8f03 View commit details
    Browse the repository at this point in the history
  2. rename all lights in prebuilt scenes

    all light game objects that exist in prebuilt scenes have now been renamed wtih the naming convention:
    
    //for all lights that are not children of sim objects or sim object prefabs
    scene|<light type>|<instance count across all scene lights of this type>
    
    //for all lights that are part of the heirarchy of a sim object
    <sim object name>|<light type>|<instance of this light type inside sim object's hierarchy>
    
    To account for scene level lights that are controlled by sim objects (like a lightswitch controlling spot lights in the scene that are not children of the lightswitch sim object itself) any sim object that controls a light will be listed in a light's LightParameter.linkedSimObj metadata. assinging linkedSimObj to serialized light info will be coming in a future commit.
    winthos committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    d9be5d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Configuration menu
    Copy the full SHA
    8a590bc View commit details
    Browse the repository at this point in the history
  2. fix to isToggled flag

    previously the isToggled metadata value was only set if the object itself was isToggleable = True. This means some objects that are not themselves isToggleable = true, like stove burners which are toggled on when a linked stove knob is toggled on, were not correctly reporting their isToggled status.
    winthos committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    dc3c072 View commit details
    Browse the repository at this point in the history
  3. buggy scale update

    mattdeitke committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    7c4d406 View commit details
    Browse the repository at this point in the history
  4. obj action

    mattdeitke committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    9d4cb43 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bfe4f28 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e4b26d4 View commit details
    Browse the repository at this point in the history
  7. update light toggle prefabs

    winthos committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    e5fcff4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7f3fe47 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    561b1a3 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    705a195 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. first set of bathroom light updates

    -also found some issues with some sinks and cabinets that needed adjustments in a few bathrooms
    winthos committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    39734e8 View commit details
    Browse the repository at this point in the history
  2. fix objects in floor

    mattdeitke committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    16c3737 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. more fixes to bathroom scenes

    winthos committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    5a41a38 View commit details
    Browse the repository at this point in the history
  2. remaining bathrooms setup

    winthos committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    3367d31 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2183611 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Configuration menu
    Copy the full SHA
    d61c7af View commit details
    Browse the repository at this point in the history
  2. rebuild

    mattdeitke committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    0ce19a9 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Configuration menu
    Copy the full SHA
    2636973 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf83ecb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f320415 View commit details
    Browse the repository at this point in the history
  4. update types

    mattdeitke committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    c1e887e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7a88562 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f371cdf View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8c47b0b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e17c01f View commit details
    Browse the repository at this point in the history
  9. cleanup renaming guids and light instances

    after many changes through all scenes to reconfigure toggleon/off light effects and light objects, certain scenes changed enough that rerunning the guid naming tool as well as the light instance renaming tool is needed
    winthos committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    54cc5ca View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. skip test

    mattdeitke committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    979e7d2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec55f42 View commit details
    Browse the repository at this point in the history
  3. fix to collider references

    these dressers were floating due to child colliders not correctly ignoring their parent rigidbody's colliders.
    winthos committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    188dd4b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d960516 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. fixing tests

    winthos committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    57af7fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7c5976d View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Configuration menu
    Copy the full SHA
    f01960c View commit details
    Browse the repository at this point in the history
  2. uhhhh

    whitespace change to trigger build
    winthos committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    a4b749a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    47845d1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    51871f8 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1085 from allenai/naive-scale-light

    Prep for Light Manager (and other updates)
    winthos committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    281b26a View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Configuration menu
    Copy the full SHA
    c9833a5 View commit details
    Browse the repository at this point in the history
  2. bug fix

    mattdeitke committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    64520fc View commit details
    Browse the repository at this point in the history
  3. pass schema in metadata

    mattdeitke committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    50f40ca View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Configuration menu
    Copy the full SHA
    95df853 View commit details
    Browse the repository at this point in the history