Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterizing height/width in ai2thor-xorg start #829

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

Lucaweihs
Copy link
Collaborator

Allowing for changing the height/width of the x display when running ai2thor-xorg start by using the --height and --width flags.

@Lucaweihs Lucaweihs requested a review from ekolve July 23, 2021 16:56
@mattdeitke
Copy link
Member

A related question here, are things slower if height and width are increased dramatically - e.g.,

DEFAULT_HEIGHT = 2500
DEFAULT_WIDTH = 2500

And is there any good reason for the defaults being fairly low? It seems many people have run into this issue, where the frames don't render fully because the height/width is too small.

@Lucaweihs
Copy link
Collaborator Author

I haven't had any chance to experiment with what the FPS impact of changing the display is, I would guess it's minimal but until we get some concrete numbers I'll keep it low for now.

@Lucaweihs Lucaweihs merged commit 5cc8fc7 into main Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants