Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path normalization on Windows #375

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix path normalization on Windows #375

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71f07b2
Fix normalization on Windows
Richienb Oct 5, 2023
2af659c
Update main.py
Richienb Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions allenact/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
name."""

import os
import posixpath

if "CUDA_DEVICE_ORDER" not in os.environ:
# Necessary to order GPUs correctly in some cases
Expand Down Expand Up @@ -370,9 +371,7 @@ def load_config(args) -> Tuple[ExperimentConfig, Dict[str, str]]:
), "The path '{}' does not seem to exist (your current working directory is '{}').".format(
args.experiment_base, os.getcwd()
)
rel_base_dir = os.path.relpath( # Normalizing string representation of path
os.path.abspath(args.experiment_base), os.getcwd()
)
rel_base_dir = posixpath.normpath(args.experiment_base)
rel_base_dot_path = rel_base_dir.replace("/", ".")
if rel_base_dot_path == ".":
rel_base_dot_path = ""
Expand Down