Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

Adding (hidden) demo for wikitables parser #25

Merged
merged 2 commits into from
Aug 29, 2018

Conversation

matt-gardner
Copy link
Contributor

This adds a demo for the wikitables parser. It's currently hidden, as it could be made to look nicer, and we're still wanting to improve the model a bit. I'm doing this now so that @kl2806 has an example to look at for building a demo for his in-progress ATIS model.

@matt-gardner
Copy link
Contributor Author

@schmmd, who's the right person to review this PR? And is there a way to see the demo that's produced by this, or does that just go to staging after the PR is merged?

@schmmd
Copy link
Member

schmmd commented Aug 29, 2018

@matt-gardner you can assign it to me or Joel. I wasn't sure it was ready for review.

Will we need the JVM dependency when we ultimately have the semantic parser demo? ;-(

It's pushed to staging once it's merged. If you want to see the demo, it's best to run the Dockerfile locally.

@matt-gardner
Copy link
Contributor Author

Yes, we'll need the jvm dependency, as it's required for wikitables. I'm surprised it wasn't already there - we're using Dockerfile.pip for what gets pushed to the allennlp docker repository?

@schmmd
Copy link
Member

schmmd commented Aug 29, 2018

@matt-gardner Dockerfile.pip just installs AllenNLP via pip. We do bake the JVM into our Dockerfile that is used for continuous integration.

app.py Show resolved Hide resolved
@matt-gardner matt-gardner merged commit 2c42de5 into allenai:master Aug 29, 2018
@matt-gardner matt-gardner deleted the wikitables-demo branch August 29, 2018 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants