This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
FairScale integration and T5-11B fine-tuning #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
epwalsh
commented
Jun 3, 2021
epwalsh
commented
Jun 3, 2021
epwalsh
changed the title
dirkgr
reviewed
Jul 6, 2021
Comment on lines
20
to
21
| // AMP is currently unusably slow with t5-11b, which be due to a bug bug within | ||
| // FairScale, but I'm not sure yet. |
dirkgr
reviewed
Jul 6, 2021
Comment on lines
65
to
73
| local wandb_callback = { | ||
| "type": "wandb", | ||
| "project": "allennlp-t5", | ||
| "entity": "allenai-team1", | ||
| "watch_model": false, | ||
| "summary_interval": 1, | ||
| "should_log_parameter_statistics": false, | ||
| "should_log_learning_rate": false, | ||
| }; |
There was a problem hiding this comment.
I don't know if we want this in a default config. Virtually everyone using this will have to change it.
Though I would be entirely in favor of having a commented-out wandb config in every jsonnet file.
| [if !debug then "callbacks"]: [wandb_callback], | ||
| }, | ||
| "distributed": { | ||
| "cuda_devices": if debug then [0, 1] else [0, 1, 2, 3, 4, 5, 6, 7], |
There was a problem hiding this comment.
I use this kind of thing to get a variable number of GPUs:
https://github.com/allenai/allennlp-models/blob/main/training_config/vision/vilbert_vqa.jsonnet#L101
| @@ -0,0 +1,125 @@ | |||
| // =================== Configurable Settings ====================== | |||
There was a problem hiding this comment.
The filename is confusing if this works for both 11b models and smaller ones.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding PR for allenai/allennlp#5242