This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Adding an optional projection layer to ElmoTokenEmbedder #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-peters
approved these changes
Apr 12, 2018
|
Adding ELMo with just dropout decreased performance by ~4%. Adding ELMo with a projection layer increased performance by ~3%. These numbers are all using the preliminary model that still doesn't quite match the original parser yet, so I'll get a clearer picture once I've managed to reproduce the original numbers. |
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matt-peters FYI. @rajasagashe's experiments with the WikiTables parser found that a projection of the ELMo representations was significantly better than just using dropout. In order to handle the projection cleanly in AllenNLP, it has to be done inside the
ElmoTokenEmbedder. This PR adds that.