Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

make predictors more discoverable #1302

Merged
merged 12 commits into from May 29, 2018
Merged

make predictors more discoverable #1302

merged 12 commits into from May 29, 2018

Conversation

DeNeutoy
Copy link
Contributor

No description provided.

@joelgrus
Copy link
Contributor

👍 this is a good idea

@DeNeutoy
Copy link
Contributor Author

Warnings look like this:

(allennlp) markn@markn ~/allen_ai/allennlp (expose-predictors) $ python
Python 3.6.3 |Anaconda, Inc.| (default, Oct  6 2017, 12:04:38)
[GCC 4.2.1 Compatible Clang 4.0.1 (tags/RELEASE_401/final)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import allennlp.service.predictors
/Users/markn/allen_ai/allennlp/allennlp/service/predictors/__init__.py:23: FutureWarning: allennlp.service.predictors.* has been depreciated. Please use allennlp.predictors.*
  "Please use allennlp.predictors.*", FutureWarning)

@DeNeutoy
Copy link
Contributor Author

Diff looks large, but it's just shuffling the predictors around.

@DeNeutoy DeNeutoy requested a review from joelgrus May 29, 2018 18:23
@matt-gardner
Copy link
Contributor

Nit: "deprecated", not "depreciated". Though the latter may also apply...

@DeNeutoy
Copy link
Contributor Author

One of the definitions of deprecated is "another word for depreciated"....

joelgrus
joelgrus approved these changes May 29, 2018
View reviewed changes
scripts/check_docs.py Outdated
@@ -26,6 +26,8 @@
'allennlp.modules.alternating_highway_lstm',
# Private base class, no docs needed.
'allennlp.modules.encoder_base',
# Deprecated in favour of allennlp.predictors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

favor 🇺🇸

@DeNeutoy DeNeutoy merged commit 5352a19 into allenai:master May 29, 2018
@DeNeutoy DeNeutoy deleted the expose-predictors branch May 29, 2018 22:50
gabrielStanovsky pushed a commit to gabrielStanovsky/allennlp that referenced this pull request Sep 7, 2018
@DeNeutoy
make predictors more discoverable (allenai#1302)
ec5f015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joelgrus joelgrus joelgrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DeNeutoy @joelgrus @matt-gardner