This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Update torch and tensorboard versions in setup.py #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
The torch and tensorboard versions in `setup.py` referenced older versions that were not consistent with `requirements.txt`. This mixup led to several `pip` warnings after installing from source: ``` allennlp 0.4.4-unreleased has requirement tensorboardX==1.0, but you'll have tensorboardx 1.2 which is incompatible. allennlp 0.4.4-unreleased has requirement torch==0.3.1, but you'll have torch 0.4.0 which is incompatible. ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The torch and tensorboard versions in
setup.pyreferenced older versions that were not consistent withrequirements.txt. This mixup led to severalpipwarnings after installing from source: