This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Make tqdm description ignore metrics starting with _ #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeNeutoy
approved these changes
Jun 26, 2018
There was a problem hiding this comment.
Can you add a note to the docstring of Model that this is the case - or even add a logging step to Trainer which informs the user that the metrics will be ignored (but still computed) the first time they are encountered. It's not exactly obvious that this would be the cause if you didn't know metrics with pre-pended underscores aren't logged.
nelson-liu
added a commit
to nelson-liu/allennlp
that referenced
this pull request
Jun 26, 2018
nelson-liu
added a commit
that referenced
this pull request
Jun 26, 2018
Continuation of #1425 , missed one
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
* Make tqdm description ignore metrics starting with _ * Add notes about this functionality * fix typo and lint * Lint , vol II
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
…nai#1430) Continuation of allenai#1425 , missed one
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tqdm currently doesn't handle long descriptions very gracefully (image below)
This PR makes the tqdm description ignore metrics with a name that begins with
_.