This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Fix incorrect default in conll2003.from_params #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeNeutoy
approved these changes
Jul 3, 2018
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
matt-peters
pushed a commit
that referenced
this pull request
Sep 10, 2018
…arning rates (ULMFiT) (#1636) * Created a STLR schedule with gradual unfreezing * Fixed parameter groups regex example * Added splitting of parameters into param groups, discriminative fine-tuning * Added splitting of predefined modules * Created a STLR schedule with gradual unfreezing * Fixed parameter groups regex example * Added splitting of parameters into param groups, discriminative fine-tuning * Fix a typo in embedding_tokens notebook. (#1449) Fix a typo in embedding_tokens notebook : The vocabulary is `token_ids` and not `tokens_ids`. * remove RegistrableVocabulary (#1454) * remove RegistrableVocabulary * add comment about special from_params logic * fix pylint * Allow to use a different validation iterator from training iterator (#1455) * Allow to use a different validation iterator from training iterator * Use validation iterator * Use validation iterator for evaluate, if present * pylint * Fix conll2003.from_params incorrect default (#1453) * fix Vocabulary.from_params to accept a dict for max_vocab_size (#1460) * fix Vocabulary.from_params to accept a dict for max_vocab_size * pylint * Fix call to vocab.token_from_index -> self.label_namespace (#1459) * Added splitting of predefined modules * Fixed off-by-one-error as suggested by Matthew * Modified SlantedTriangular learning rate schedule name and id * Renamed epoch_no to num_layers_to_unfreeze * Addressed pylint issues * Replaced print with logger.info * Moved specification of discriminative fine-tuning from trainer to learning rate scheduler * Added pylint: disable=protected-access * Added handling when optimizer is a string * Fixed bug with negative lr due to frozen_steps > 0 when not freezing; removed lr argument; added modification of base_lrs * Added test for slanted triangular learning rate schedule * Removed automatic assignment to param_groups in trainer.py, added check in STLR * nits and pylint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.