This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Fix calculation of estimated time remaining #1631
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line:
allennlp/allennlp/training/trainer.py
Line 763 in 6b37dd2
calculates (or incorrectly formats) the wrong estimated time remaining when
estimated_time_remaining
is greater than 1 day, sincetime.gmtime
interprets the number of seconds as time since the epoch, not a time duration.