Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Fix calculation of estimated time remaining #1631

Merged
merged 1 commit into from Aug 20, 2018

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Aug 20, 2018

This line:

formatted_time = time.strftime("%H:%M:%S", time.gmtime(estimated_time_remaining))

calculates (or incorrectly formats) the wrong estimated time remaining when estimated_time_remaining is greater than 1 day, since time.gmtime interprets the number of seconds as time since the epoch, not a time duration.

Copy link
Contributor

@matt-gardner matt-gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matt-gardner matt-gardner merged commit 14aee14 into allenai:master Aug 20, 2018
@epwalsh epwalsh deleted the time-remaining-fix branch August 23, 2018 00:41
gabrielStanovsky pushed a commit to gabrielStanovsky/allennlp that referenced this pull request Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants