This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Removing last_dim_*softmax #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeNeutoy
approved these changes
Aug 29, 2018
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
* Removing last_dim_*softmax * Remove unused import * Fix sum dimension
|
I'm upgrading a system from this deprecated version of allennlp. Does |
|
Yes, the behavior is the same. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when we rolled our own
masked_softmaxandmasked_log_softmax, we had to treat higher-dimension inputs separately. We don't need to do that anymore, and so we should deprecatelast_dim_softmaxandlast_dim_log_softmaxin favor of just using the other versions, which will be more efficient.