This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Add best span string as output to predict_span
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmmd
approved these changes
Aug 28, 2017
|
Matt, I had gotten confused because I will fix the IO of |
schmmd
added a commit
that referenced
this pull request
Feb 26, 2020
* Limit the max input of text inputs and areas. * maxlength -> maxLength
schmmd
pushed a commit
that referenced
this pull request
Feb 26, 2020
schmmd
pushed a commit
that referenced
this pull request
Feb 26, 2020
schmmd
pushed a commit
that referenced
this pull request
Feb 26, 2020
* Set default input limits for forms (#209) * Limit the max input of text inputs and areas. * maxlength -> maxLength * Use rudder for deploy related functionality. (#211) * Use rudder for deploy related functionality. This ensures that the application is deployed to the latest n' greatest skiff cluster. * Use the right image path. * Release pending changes. (#212) (#213) * Set default input limits for forms (#209) * Use rudder for deploy related functionality. (#211) * Bert srl (#214) * update srl model * update description * bump to commit which includes srl model * set timeout to 15 minutes * update to latest image, add numbers (#216)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@schmmd, if you really want the tokenized question and/or passage for whatever reason, you could modify the BiDAF predictor to return the tokens in the resulting json:
allennlp/allennlp/service/predictors/bidaf.py
Line 17 in 311db7f
This PR should get you a decent pass at an answer string, though.