This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Warn default value of min_padding_length #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gardner
reviewed
Jan 8, 2019
| f"which can cause some subtle bugs (more info see {url}). " | ||
| "Strongly recommend to set a value, usually the maximum size " | ||
| "of the convolutional layer size when using CnnEncoder.", | ||
| FutureWarning) |
There was a problem hiding this comment.
I don't think FutureWarning is right here - nothing is going to change in the future, it's just a warning that the user might have buggy code. Maybe the default of UserWarning is correct here?
WrRan
commented
Jan 9, 2019
| @@ -1,8 +1,6 @@ | |||
| # pylint: disable=no-self-use,invalid-name | |||
| from collections import defaultdict | |||
|
|
|||
| import warnings | |||
|
|
|||
matt-gardner
reviewed
Jan 9, 2019
There was a problem hiding this comment.
Thanks, this looks good. There is one other important thing to fix, though: this adds a whole bunch of new warnings thrown in our test suite. Those need to be fixed or squelched before this can be merged. Also, in your other PR, UserWarning and FutureWarning should be treated as an error, just like DeprecationWarning is.
|
Got it. I am gonna to fix it. |
|
Please have a look. I think related warnings are clear now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2287.