This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Fix TextField padding when there are no tokens #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryant1410
changed the title
|
Thanks! Seems like a good improvement but I requested a review from someone whose a bit deeper in the codebase. |
matt-gardner
approved these changes
May 30, 2019
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
* Add test for getting the tensor of empty text field with token indexer * Fix TextField padding when there are no tokens
TalSchuster
pushed a commit
to TalSchuster/allennlp-MultiLang
that referenced
this pull request
Feb 20, 2020
* Add test for getting the tensor of empty text field with token indexer * Fix TextField padding when there are no tokens
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to (fixes?) #1591
The bug is about some
TextFieldin some instance of the dataset that has no tokens and, at the same time, aTokenCharactersIndexeris used. Whento_tensoris called it fails.