Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

fix behavior when num_serialized_models_to_keep is 0 #2880

Merged
merged 3 commits into from
Jun 27, 2019

Conversation

joelgrus
Copy link
Contributor

@joelgrus joelgrus commented May 23, 2019

this is the bug that @OyvindTafjord ran into

Copy link
Contributor

@DeNeutoy DeNeutoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is important let's merge

@joelgrus joelgrus merged commit c85dcfc into allenai:master Jun 27, 2019
reiyw pushed a commit to reiyw/allennlp that referenced this pull request Nov 12, 2019
* fix behavior when num_serialized_models_to_keep is 0

* pylint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants