Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Change blueprint to image in run_with_beaker #2903

Merged
merged 2 commits into from
May 31, 2019

Conversation

pdasigi
Copy link
Member

@pdasigi pdasigi commented May 29, 2019

The subprocess call that used to create a blueprint now throws a warning, which is also captured and interpreted as the name of a blueprint, causing the experiment creation to fail. This update fixes that issue as well.

@pdasigi pdasigi requested a review from schmmd May 29, 2019 18:52
Copy link
Member

@schmmd schmmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@kernelmachine kernelmachine merged commit 5393882 into allenai:master May 31, 2019
Whu-wxy added a commit to Whu-wxy/allennlp that referenced this pull request Jun 4, 2019
Change blueprint to image in run_with_beaker (allenai#2903)
reiyw pushed a commit to reiyw/allennlp that referenced this pull request Nov 12, 2019
* blueprint -> image

* separate docker image from beaker image
TalSchuster pushed a commit to TalSchuster/allennlp-MultiLang that referenced this pull request Feb 20, 2020
* blueprint -> image

* separate docker image from beaker image
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants