Fixed minor error while calculating span accuracy

[abhishek0318]

Inputs to BooleanAccuracy must have the same dimensions. Here, the first argument has dimensions (batch size, 2), while the second argument has dimensions (batch size, 1, 2). Changing torch.stack to torch.cat makes the dimension of the second argument (batch size, 2).

Note that span accuracy obtained earlier was not incorrect because of the way accuracy was being computed internally.

[kl2806]

Thanks! Would you mind raising a config error checking that they are the same dimension similar to: https://github.com/allenai/allennlp/blob/master/allennlp/training/metrics/categorical_accuracy.py#L48
and a test that checks for this similar to

allennlp/allennlp/tests/training/metrics/categorical_accuracy_test.py

Line 79 in 1938a5a

with pytest.raises(ConfigurationError):

[matt-gardner]

Minor point: config errors should only be used when the error reasonably came from a configuration file problem. That's probably not the case here, and a value error would be more appropriate.

[abhishek0318]

Thanks! Would you mind raising a config error checking that they are the same dimension similar to and a test that checks for this similar to.

Sure. I will do it over the weekend.

[abhishek0318]

I have added the checks and the corresponding tests. Please take a look.

[kl2806]

LGTM, I made some minor changes