This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Use unsigned s3 requests when missing credentials #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Disclosure: this is missing a test case because I'm not sure how to create a test environment with / without credentials. Suggestions welcome, if you think it's necessary. I did of course run it locally both with and without creds to confirm that it works. |
matt-gardner
approved these changes
Jun 10, 2019
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
* use unsigned s3 requests when missing credentials * revert to using resource
matt-peters
pushed a commit
to matt-peters/allennlp
that referenced
this pull request
Jan 8, 2020
* use unsigned s3 requests when missing credentials * revert to using resource
TalSchuster
pushed a commit
to TalSchuster/allennlp-MultiLang
that referenced
this pull request
Feb 20, 2020
* use unsigned s3 requests when missing credentials * revert to using resource
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2929