Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

fix type in vocab config #2977

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Conversation

joelgrus
Copy link
Contributor

fixes #2402

@joelgrus joelgrus requested a review from nelson-liu June 19, 2019 21:02
Copy link
Contributor

@nelson-liu nelson-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response, LGTM

@joelgrus joelgrus merged commit 2cce412 into allenai:master Jun 27, 2019
@joelgrus joelgrus deleted the config-wizard-types branch June 27, 2019 18:35
reiyw pushed a commit to reiyw/allennlp that referenced this pull request Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config Wizard incorrectly infers type of Vocabulary min_count
2 participants