This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Fix error in BooleanAccuracy when total count is 0 #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek0318
changed the title
brendan-ai2
reviewed
Jun 28, 2019
| @@ -84,7 +84,10 @@ def get_metric(self, reset: bool = False): | |||
| ------- | |||
| The accumulated accuracy. | |||
| """ | |||
| accuracy = float(self._correct_count) / float(self._total_count) | |||
| if self._total_count > 1e-12: | |||
There was a problem hiding this comment.
Can't you just test this against 0?
matt-gardner
approved these changes
Jul 8, 2019
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
* Fix error when count is 0 * Update boolean_accuracy.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2822