This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Add options for focal loss #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add focal loss to deal with class imbalance
|
Sorry, it seems there are some problems. But it works fine in my local copy. |
|
You can see it yourself here: http://build.allennlp.org/viewLog.html?buildId=17043&buildTypeId=AllenNLP_AllenNLPPullRequests&tab=buildLog. Just log in as a guest. |
|
Thanks. Did not see the guest option. Will get back when I figure this out. |
It was in the wrong place. Sorry.
|
Finally here. Not an easy job to make these checkers happy. |
matt-gardner
reviewed
Jul 9, 2019
For more clear cross_entropy formulation
Combine everything into `weights` and avoid reference to local variables later.
Add `@flaky` also to token-average tests.
|
It seems moving where to combine the weight brings in new problem. Will look at it later. |
Avoid involving `gamma` or `alpha` in average.
More tolerance to token average so the change it complaint < 1/1000.
matt-gardner
approved these changes
Jul 10, 2019
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
* Add options for focal loss Add focal loss to deal with class imbalance * Fix some typing problems * Update util.py * Update util.py * Update util.py * Fix too long lines * Fix keyword argument alert * Update util.py * Update util.py * Fix a problem focal loss not activated * Add test for focal loss gamma * Fix some problem with decimal precision problems * Add focal loss alpha test * Update util_test.py * Update util.py * Update util_test.py * Address some pylint and mypy problems * Update util.py * Update util.py * Update util.py * Update util.py * Update util_test.py * Update util_test.py It was in the wrong place. Sorry. * restore not-callable after torch.tensor() * Update util_test.py For more clear cross_entropy formulation * Update util.py Combine everything into `weights` and avoid reference to local variables later. * Update util_test.py Add `@flaky` also to token-average tests. * Update util.py Avoid involving `gamma` or `alpha` in average. * Update util_test.py * Update util_test.py More tolerance to token average so the change it complaint < 1/1000.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add focal loss to deal with class imbalance