This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Minor WTQ ERM model and dataset reader fixes for demo #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gardner
approved these changes
Jul 16, 2019
| # We don't need a separate beam search since the trainer does that already. But we're defining one just to | ||
| # be able to use interactive beam search (a functionality that's only implemented in the ``BeamSearch`` | ||
| # class) in the demo. We'll use this only at test time. | ||
| self._beam_search = BeamSearch(beam_size=decoder_beam_size) # type: ignore |
There was a problem hiding this comment.
Why do you need type: ignore here?
There was a problem hiding this comment.
Mypy complained that it needs type annotation for that variable. I assumed that's a mypy bug since the variable is actually being defined there.
There was a problem hiding this comment.
Maybe try self._beam_search: BeamSearch = ...?
There was a problem hiding this comment.
Looks like that works. Thanks!
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
* model dataset reader fixes for demo * fixed a typo * mypy ignore * make mypy happy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we used the final states from the ERM trainer both for training and prediction, but that meant that we could not use interactive beam search on an ERM trained model. The main change in this PR is to use beam search in the ERM model while testing. I confirmed that the dev accuracy of a trained model remains the same after this change.