This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Add dropout option for BERT Pooler #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeNeutoy
approved these changes
Aug 7, 2019
| def __init__(self, pretrained_model: Union[str, BertModel], requires_grad: bool = True) -> None: | ||
| def __init__(self, | ||
| pretrained_model: Union[str, BertModel], | ||
| dropout: float = 0.0, |
There was a problem hiding this comment.
Please could you change the position of this argument to be last, so that it doesn't introduce a breaking change?
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
* Add dropout option for BERT Pooler * Change order of arguments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional dropout to BERT after the pooling operation but before the final feedforward. This mirrors
BertForClassification, which has a dropout at this step.