This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
switch for DataIterators whether smaller batches should be skipped #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnschmit
changed the title
BucketIterator whether smaller batches should be skipped
DeNeutoy
reviewed
Aug 12, 2019
|
Yes, of course, I added them. Thanks for the hint! |
|
Great, thanks a lot! |
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
…llenai#3140) * added a switch to bucket_iterator whether batches smaller than batch_size should be skipped * added documentation for the new switch * added the switch also to `HomogeneousBatchIterator` * added unit tests for bucket and homogeneous iterator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3118