Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Upgrade minimum spacy to 2.1.0 #3152

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Upgrade minimum spacy to 2.1.0 #3152

merged 2 commits into from
Aug 13, 2019

Conversation

schmmd
Copy link
Member

@schmmd schmmd commented Aug 13, 2019

Fixes #3149

@schmmd schmmd requested a review from DeNeutoy August 13, 2019 21:00
DeNeutoy
DeNeutoy suggested changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@DeNeutoy DeNeutoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change the version in setup.py

DeNeutoy
DeNeutoy approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@DeNeutoy DeNeutoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after that though

@DeNeutoy DeNeutoy merged commit 3ef43c9 into master Aug 13, 2019
@DeNeutoy DeNeutoy deleted the upgrade-minimum-spacy branch August 13, 2019 23:34
reiyw pushed a commit to reiyw/allennlp that referenced this pull request Nov 12, 2019
@schmmd @reiyw
Upgrade minimum spacy to 2.1.0 (allenai#3152)
fc12680 
* Upgrade minimum spacy to 2.1.0

* Fix in setup.py too.
@DeNeutoy DeNeutoy mentioned this pull request Nov 19, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DeNeutoy DeNeutoy DeNeutoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AllenNLP Fails if en_core_web_sm already exists
2 participants
@schmmd @DeNeutoy