Clean up the command to create a commit list. #4263
Conversation
RELEASE_PROCESS.md
Outdated
|
|
||
| ```fish | ||
| git log (git describe --always --tags --abbrev=0 HEAD^^)..HEAD^ --oneline | ||
| git log v0.9.0..v1.0.0rc4 --oneline |
There was a problem hiding this comment.
I feel like this actually makes it more error prone since you can't just copy and paste this commad.. you'd have to edit it to change the tags.
And git describe --always --tags --abbrev=0 HEAD^^ just prints the name of the previous tag.
Would doing
| git log v0.9.0..v1.0.0rc4 --oneline | |
| git log `git describe --always --tags --abbrev=0 $TAG^`..$TAG --oneline |
make it more clear?
There was a problem hiding this comment.
Yes, substantially. It would also reduce error, as the previous command depends on the commit you're at.
| Or, if you're using fish, | ||
|
|
||
| ```fish | ||
| git log (git describe --always --tags --abbrev=0 HEAD^^)..HEAD^ --oneline |
There was a problem hiding this comment.
I like having this because I'm a fisher, so I can just copy and paste it. That said, I'm not opposed to removing it. I could always just stuff this into a function in my dotfiles.
There was a problem hiding this comment.
I am too. I only deleted it because my change made the command identical for fish and bash. Your modifications added some bash/fish-specific stuff back in.
There was a problem hiding this comment.
Pete--I added a fish command back in. I recommend taking a second look.
Co-authored-by: Evan Pete Walsh <epwalsh10@gmail.com>
Co-authored-by: Evan Pete Walsh <epwalsh10@gmail.com>
I'm not really sure what the previous command does. It seems easier if we simplify the syntax to specify the version range. I think it will make it less likely to make a mistake.