Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Make returning token type id default in transformers intra word tokenization. #4758

Merged

Conversation

mklimasz
Copy link
Contributor

@mklimasz mklimasz commented Oct 28, 2020

Addressing #4757 bug - check description there.

I can duplicate intra tokenizer test with use_fast False flag, but not sure if you want to keep such tests (there can be multiple of such tests with different flags).

Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mklimasz! Could you just add a note about this to the "Fixed" section of the CHANGELOG?

Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@epwalsh epwalsh merged commit baca754 into allenai:master Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants