This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Ensure all relevant allennlp submodules are imported with import_plugins()
#5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
changed the title
epwalsh
commented
Jun 7, 2021
| @@ -22,8 +22,7 @@ | |||
| from allennlp.common.file_utils import cached_path | |||
| from allennlp.models.archival import CONFIG_NAME | |||
|
|
|||
| logger = logging.getLogger() | |||
| logger.setLevel(logging.ERROR) | |||
There was a problem hiding this comment.
This was messing with the global log level.
epwalsh
changed the title
import_plugins()
dirkgr
approved these changes
Jun 7, 2021
| """ | ||
| Import all submodules under the given package. | ||
| Primarily useful so that people using AllenNLP as a library | ||
| can specify their own custom packages and have their custom | ||
| classes get loaded and registered. | ||
| """ | ||
| if exclude and package_name in exclude: |
There was a problem hiding this comment.
Looks like exclude should be a Optional[Set[str]]?
Abhishek-P
pushed a commit
to Abhishek-P/allennlp
that referenced
this pull request
Aug 11, 2021
…gins()` (allenai#5246) * ensure allennlp is a default plugin * fix logging issue * fixes * actually fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why "bias_mitigator_applicator" wasn't showing up as a registered model name. This fixes that.