This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Configure validation frequency #5534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
suggested changes
Jan 4, 2022
There was a problem hiding this comment.
Thanks @JohnGiorgi, this seems like a good approach. I have a couple comments 👇
| class ShouldValidateCallback(TrainerCallback): | ||
| """ | ||
| A callback that you can pass to the `GradientDescentTrainer` to change the frequency of | ||
| validation during training. If `start_validation` is not `None`, validation will not occur until |
There was a problem hiding this comment.
I think validation_start sounds a little better than start_validation
There was a problem hiding this comment.
Changed! Yeah, I was struggling with the naming, if you have any other name change suggestions let me know!
epwalsh
reviewed
Jan 4, 2022
Co-authored-by: Pete <epwalsh10@gmail.com>
epwalsh
reviewed
Jan 4, 2022
Co-authored-by: Pete <epwalsh10@gmail.com>
JohnGiorgi
commented
Jan 4, 2022
Cool! Thanks @epwalsh |
JohnGiorgi
added a commit
to JohnGiorgi/allennlp
that referenced
this pull request
Jan 4, 2022
This was referenced Jan 4, 2022
dirkgr
added a commit
that referenced
this pull request
Jan 12, 2022
Co-authored-by: Dirk Groeneveld <dirkg@allenai.org>
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5214 .
Changes proposed in this pull request:
GradientDescentTrainer(_should_validate_this_epoch) that controls whether validation will occur at the end of an epoch.ShouldValidateCallbackthat allows a user to configure validation frequency.validation_start) and the validation frequency (withvalidation_interval).Before submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.After submitting
codecov/patchreports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.