Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Add flair as an alternative #5712

Merged
merged 2 commits into from Sep 28, 2022
Merged

Add flair as an alternative #5712

merged 2 commits into from Sep 28, 2022

Conversation

bratao
Copy link
Contributor

@bratao bratao commented Sep 24, 2022

Changes proposed in this pull request:

I´m super sad that allennllp is veen deprecated. I was looking for alternatives to port my projects and I think that the best candidate is the Flair library. It have many of qualities of Allennlp such as the academic focus and the framework composability. I think it would be nice to add as an alternative.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bratao, happy to add this. Just a minor suggestion on wording

README.md Outdated Show resolved Hide resolved
@dirkgr
Copy link
Member

dirkgr commented Sep 28, 2022

@bratao, if you want to step up as a maintainer of AllenNLP, we can do that. We can give you the necessary permissions now. It would give us enough time to do a soft transition until December.

Co-authored-by: Pete <epwalsh10@gmail.com>
@dirkgr
Copy link
Member

dirkgr commented Sep 28, 2022

Another comment: Did you consider https://github.com/allenai/tango as an upgrade? You would find the configuration language and the trainer quite familiar.

One way of looking at Tango is this: In AllenNLP, you always run three steps: Load data, train model, evaluate. In Tango, you can run those steps, but also other, custom steps, and you can run them in more complicated configurations than just in order.

@dirkgr dirkgr enabled auto-merge (squash) September 28, 2022 00:53
@dirkgr dirkgr merged commit 9f879b0 into allenai:main Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants