You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# if not set; it will potentially not write to the output stream
# in case a tagger emits no spans
attributes_by_stream[tagger_output.path] = {}
tagger_output.path is the same for all the taggers in the list, but attributes_by_stream[tagger_output.path] will be set to empty dictionary when looping through the taggers, leaving only the attributes from the last tagger in the list.
This bug is not present in version 0.9.4.
I would submit a pull request, but I am not sure what these three lines are supposed to fix.
The text was updated successfully, but these errors were encountered:
…#114)
* do not overwrite tagger outputs with the same output path
* added test for failure
* removed unused import
* caught error
---------
Co-authored-by: Luca Soldaini <luca@soldaini.net>
Since upgrading dolma to version 1.0.0 I only get the attributes from the last tagger in the list.
I think the problem is here:
dolma/python/dolma/core/runtime.py
Lines 198 to 200 in a74b78a
tagger_output.path
is the same for all the taggers in the list, butattributes_by_stream[tagger_output.path]
will be set to empty dictionary when looping through the taggers, leaving only the attributes from the last tagger in the list.This bug is not present in version 0.9.4.
I would submit a pull request, but I am not sure what these three lines are supposed to fix.
The text was updated successfully, but these errors were encountered: