sync with clab/dynet #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove previous dropout behavior. * set_dropout now indicates dropout_rate, not retention rate. * weights are scaled when dropout is applied, so no scaling is needed at test time (just set dropout_rate = 0.0)
…nto vanilla_gal_dropout
This is preferable over manually installing Eigen, because that will make /usr/local a mixture of Homebrew and local packages.
A pull request for clab#242 (greedy decoding and vectorization in attention.py)
Fix dlc TYPOs
Better initializers
Debugging documents
Fix struct names not appearing in doc
Fix incorrect assignment in treelstm.cc
Fix CUDA linker issue with -lcublas.
When initializing, we need to call it as dynet::initialize(argc, argv,true); to maked the shared params are in use.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doesn't appear there's any breaking changes, except for some CMake difference that requires a slightly different eigen path (I don't really understand why, but I updated the README)