Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks 1511-1513 #486

Draft
wants to merge 95 commits into
base: master
Choose a base branch
from
Draft

Tasks 1511-1513 #486

wants to merge 95 commits into from

Conversation

sumantapatro
Copy link
Contributor

Task 1511

Added task1511_country_life_expectancy
Copy link
Contributor Author

@sumantapatro sumantapatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added task1511_country_life_expectancy

@swarooprm
Copy link
Contributor

@sumantapatro, this PR is showing that 13 files are being changed, I guess you want to push 1 file since the rest of the 12 files are already merged.
Could you fetch upstream and sync before pushing changes?
You can also create a branch instead of merging from the master, this is optional though.

Copy link
Contributor Author

@sumantapatro sumantapatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ReadMe and added Task 1511

@sumantapatro sumantapatro changed the title Task 1511 Tasks 1511-1512 Oct 27, 2021
Added task1512_country_population in ReadMe
Added task1512_country_population
Copy link
Contributor Author

@sumantapatro sumantapatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added task1512_country_population

Added task1513_country_landlocked in ReadMe
Added task1513_country_landlocked
@sumantapatro sumantapatro changed the title Tasks 1511-1512 Tasks 1511-1513 Oct 27, 2021
@aarunku5
Copy link
Contributor

Thanks!

For tasks 1511, 1512- these aren't exactly human-achievable tasks. Can you modify both tasks to give rounded estimates? For instance- life expectancy can be 60-70 years and population can be 1.2 million

In 1513, define what landlocked is in the definition

Copy link
Contributor Author

@sumantapatro sumantapatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Task1513 Definition

@aarunku5
Copy link
Contributor

1513 looks good. To clarify, for 1511 and 1512, can you make updates to the examples and instances as follows:

1511
"input":"Angola",
"output":"30-40"
"explanation":"Life expectancy of the given country Angola is between 30-40 in the year 2014"

1512
"input":"Angola",
"output":"12.8 million",
"explanation":"Population of the given country Angola is 12.8 million in the year 2000"

@aarunku5
Copy link
Contributor

aarunku5 commented Nov 2, 2021

@sumantapatro any updates on your end so we can proceed with this PR?

@sumantapatro
Copy link
Contributor Author

@sumantapatro any updates on your end so we can proceed with this PR?

@aarunku5 Task1511 and 1512 are created based on the data-set available in the mentioned URLs as defined in the respective tasks.

@danyaljj danyaljj added the onhold label Nov 4, 2021
@danyaljj danyaljj marked this pull request as draft November 4, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants