Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try PyTorch FSDP "HYBRID_SHARD" strategy #38

Closed
epwalsh opened this issue Mar 13, 2023 · 1 comment
Closed

Try PyTorch FSDP "HYBRID_SHARD" strategy #38

epwalsh opened this issue Mar 13, 2023 · 1 comment
Labels
difficulty/easy Easy issue to tackle, may take a couple hours project/model Related to modeling decisions and implementations severity/should Something that should be implemented/fixed status/blocked Progress can't be made because we're waiting on something outside of our control

Comments

@epwalsh
Copy link
Member

epwalsh commented Mar 13, 2023

While this wasn't implemented as of PyTorch 1.13.1, it appears it's going to be in the next release because it's implemented in the master branch: https://github.com/pytorch/pytorch/blob/master/torch/distributed/fsdp/api.py#L31.

@epwalsh epwalsh added project/model Related to modeling decisions and implementations severity/should Something that should be implemented/fixed status/blocked Progress can't be made because we're waiting on something outside of our control difficulty/easy Easy issue to tackle, may take a couple hours labels Mar 13, 2023
@dirkgr
Copy link
Member

dirkgr commented Apr 30, 2024

This is done.

@dirkgr dirkgr closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/easy Easy issue to tackle, may take a couple hours project/model Related to modeling decisions and implementations severity/should Something that should be implemented/fixed status/blocked Progress can't be made because we're waiting on something outside of our control
Projects
None yet
Development

No branches or pull requests

2 participants